Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Refactoring builders #182

Closed
willdurand opened this issue Apr 23, 2012 · 7 comments
Closed

[RFC] Refactoring builders #182

willdurand opened this issue Apr 23, 2012 · 7 comments
Assignees
Labels

Comments

@willdurand
Copy link
Contributor

As stated during the IRC meeting, we will postpone this part but we need to decide how to refactor these builders before a stable release even if alpha/beta versions will be probably released without these new builders.

The first option was TwigGenerator but some people (@beberlei, @themouette, and me) feel uncomfortable with that, because it will be hard to reproduce things like filters. Here is a old project which uses TwigGenerator: https://github.com/fzaninotto/Doctrine2ActiveRecord.

What?

  • We need a proper Twig implementations for builders;
  • We need to reproduce all features including filters;
  • We need to decouple data, and views.

How?

  • We will use Twig;
  • TwigGenerator is an option;
  • Mondator, feedbacks?;
  • Don't talk about AST.

The Plan

The first step is to rewrite simple builders using Twig, and to explain pros/cons.
If we are able to rewrite builders using Twig, let's go. Otherwise another option will be discussed.

@jaugustin
Copy link
Member

I will write extra RFC, about what we can do with twig and behavior

@mpscholten
Copy link
Member

Anything new about this?
In my opinion this would make our code much more readable, so I would really like to start building a prototype of the twig integration if you agree?

@cristianoc72
Copy link
Member

Sure! This issue isn't abandoned but in our last chat we considered it not to be a priority for 2.0 release.
So, go ahead and good luck!

@jaugustin
Copy link
Member

Yes, this could help a lot to build clean code ;) et help to write behavior, but this is postponed to a 2.x version, unless someone do an awesome PR ;)

@marcj
Copy link
Member

marcj commented Oct 4, 2013

@cristianoc72, which chat do you mean? can we read a log of it?

@cristianoc72
Copy link
Member

@dereuromark
Copy link
Contributor

I will close these stale and old tickets.
We can open new ones as per needs, but they are just collecting dust here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants