-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Refactoring builders #182
Comments
I will write extra RFC, about what we can do with twig and behavior |
Anything new about this? |
Sure! This issue isn't abandoned but in our last chat we considered it not to be a priority for 2.0 release. |
Yes, this could help a lot to build clean code ;) et help to write behavior, but this is postponed to a 2.x version, unless someone do an awesome PR ;) |
@cristianoc72, which chat do you mean? can we read a log of it? |
I will close these stale and old tickets. |
As stated during the IRC meeting, we will postpone this part but we need to decide how to refactor these builders before a stable release even if alpha/beta versions will be probably released without these new builders.
The first option was TwigGenerator but some people (@beberlei, @themouette, and me) feel uncomfortable with that, because it will be hard to reproduce things like filters. Here is a old project which uses TwigGenerator: https://github.com/fzaninotto/Doctrine2ActiveRecord.
What?
How?
The Plan
The first step is to rewrite simple builders using Twig, and to explain pros/cons.
If we are able to rewrite builders using Twig, let's go. Otherwise another option will be discussed.
The text was updated successfully, but these errors were encountered: