Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to display images inline for annotation values #315

Open
matthewhorridge opened this issue Feb 4, 2016 · 4 comments
Open

Add option to display images inline for annotation values #315

matthewhorridge opened this issue Feb 4, 2016 · 4 comments
Labels
Type: Enhancement A request for a change that is an enhancement

Comments

@matthewhorridge
Copy link
Contributor

For annotation values that are URLs that point to images it should be possible to display thumbnails of the images inline.

@csnyulas
Copy link
Member

This works only for image URLs that are specified as IRI annotation values, but not for URLs specified as literal annotation values (such as xsd:string, xsd:anyURI, or even literals of unspecified types).

@csnyulas csnyulas added the Type: Enhancement A request for a change that is an enhancement label Mar 10, 2016
@csnyulas csnyulas reopened this Mar 10, 2016
@csnyulas
Copy link
Member

BTW, it should work for GIF images as well, which is currently not supported.

@csnyulas
Copy link
Member

Images reference by a local file URI, such as file:///home/user1/Pictures/pic1.png, are not shown.
It would be definitely nice to show those, as well, in addition to the http URLs.

@csnyulas csnyulas reopened this Feb 20, 2017
@csnyulas
Copy link
Member

And, BTW, annotation values that contain other text besides the image URLs do not get the URL replaced by the image. For example:

blablabla https://assets-cdn.github.com/images/modules/logos_page/Octocat.png blabla continued
or even if the image is in a separate line like this
https://assets-cdn.github.com/images/modules/logos_page/Octocat.png
it is not displayed.

Not sure, if this is a problem that we want to fix, of not, but I thought I make a note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement A request for a change that is an enhancement
Projects
None yet
Development

No branches or pull requests

2 participants