Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thin walls: improvement #1028

Open
supermerill opened this issue Jul 4, 2018 · 6 comments
Open

Thin walls: improvement #1028

supermerill opened this issue Jul 4, 2018 · 6 comments

Comments

@supermerill
Copy link
Contributor

supermerill commented Jul 4, 2018

Hi,
I just slain my personal dragon by improving the thin wall algorithm.

  • no more strange turn at end => fusion of voronoi end lines when they are near enough
  • anchoring inside the perimeters => extends the lines end inside the perimeter to join it. A gui parameter can be created to adjust it if needed (currently, it extends to meet the center).
  • conservation of too small segments of thin walls when they are crossing each other => modification of the fusion algorithm to select the most strait path instead of a random one
  • no more cutting of small walls path by the gcode writer (no_sort for each thin wall extrusion) to have nice long lines of extrusions instead of many smaller.

before:

smallwall_problem
thin_wall_badd

after:

thin_wall_happy
thin_wall_success

Do you want a pull request?

for the curious: f685442

@lordofhyphens
Copy link
Contributor

This has been merged into upstream Slic3r

@bubnikv
Copy link
Collaborator

bubnikv commented Jul 17, 2018

@lukasmatena Would you please review this code? Thanks.

@supermerill
Copy link
Contributor Author

If you want to make a code review, i should create a pull request as all the needed code isn't in this commit.

@wavexx
Copy link
Contributor

wavexx commented Feb 22, 2019

Would you make a proper PR for this? I think it would also be helpful also for prusa to keep track of other tweaks you did beyond the mentioned commit (if any).

@supermerill
Copy link
Contributor Author

I will update it when the one in the mainline branch will be merged.

@wavexx
Copy link
Contributor

wavexx commented Feb 24, 2019

There's so much development to love both in slic3r mainline and prusa's fork... 😢
I switch between the two depending on the part I need to print!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants