Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thin wall detection reversed #1389

Open
ArjanStr opened this issue Nov 5, 2018 · 12 comments
Open

Thin wall detection reversed #1389

ArjanStr opened this issue Nov 5, 2018 · 12 comments
Labels

Comments

@ArjanStr
Copy link

ArjanStr commented Nov 5, 2018

Version

1.41.1+win64

Use About->About Slic3r for release versions

For -dev versions, use git describe --tag or get the hash value for the version you downloaded or git rev-parse HEAD

Operating system type + version

Windows10

Behavior

If thin wall detection is checked, slicer does NOT detect thin walls.
The selection is reversed.

Is this a new feature request?

STL/Config (.ZIP) where problem occurs

Upload a zipped copy of an STL and your config (File -> Export Config)

@lostcontrol
Copy link

Ah yes, seems you're right. Good catch!!!

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 15, 2018

@FidelCapo would you please confirm this? Thanks.

@FidelCapo
Copy link
Collaborator

I am not able to reproduce this error. I've tested the "detect thin perimeters" feature on the attached object, and it seems to me that the function works correctly.

Model sliced with "detect thin perimeters" feature disabled
screenshot 2018-11-15 at 10 33 31

Model sliced with "detect thin perimeters" feature enabled
screenshot 2018-11-15 at 10 34 39

Can you please send me a 3MF file where the issue is showing?

@lostcontrol
Copy link

lostcontrol commented Nov 15, 2018

This is with the option enabled:
screenshot from 2018-11-15 22-23-52
and this with the option disabled:
screenshot from 2018-11-15 22-24-27
Look at the 4 holes at the left and right of the object. Actually the setting is called "Detect thin walls"

@wavexx
Copy link
Contributor

wavexx commented Nov 16, 2018

I also have some weird issues with "thin wall" detection. As the OP, I mostly do mechanical parts, and design features with exact perimeter sizes in mind.

The option works mostly as intended. A 0.4mm wall will not be printed with a 0.4mm nozzle unless the option is switched on.

However, there are definitely some corner cases where thin wall detection actually prevents some thin (and not so thin) features to be printed. I'm trying to find the specific cases where I had this problem in the past and post some models.

@bubnikv
Copy link
Collaborator

bubnikv commented Dec 13, 2018

@lostcontrol The first image shows the effects of the thin walls detection to me indeed, so the switch is certainly correct, only the "detect thin walls" does not work optimally. Your model is a good test object for @supermerill , who is currently reworking the gap fill algorithm.

@supermerill
Copy link
Contributor

gap fill algorithm

It's in the review process in slic3r upstream. If/when merged, I will do the same here.

@lostcontrol
Copy link

@bubnikv ok, makes sense. @supermerill here is the STL file. I use 3 shells and I think my layer width should be at 0.45mm. I can export a AMF or 3MF file if you want.

@supermerill
Copy link
Contributor

@ lostcontrol I don't know why you give me this stl but i can slice it and i can have thin walls.
thin_toad

@lostcontrol
Copy link

@supermerill because @bubnikv said a few comments that:

@lostcontrol The first image shows the effects of the thin walls detection to me indeed, so the switch is certainly correct, only the "detect thin walls" does not work optimally. Your model is a good test object for @supermerill , who is currently reworking the gap fill algorithm.

That's why I attached that model. Have a look at the same model but now saved as AMF with my settings which should show the problem. At least it does look weird for me with Slic3r 1.14.1:

screenshot from 2018-12-14 20-57-18

@supermerill
Copy link
Contributor

On my fork, coming into slic3rPE next year:
thin_ok

@lostcontrol
Copy link

@supermerill looks great, looking forward to it 👍 But why do you only have 1 shell? How does it look like with 3 shells?

This was referenced Jan 27, 2019
@rtyr rtyr added the gap fill label Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants