Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Blob Sidecars SSZ Encoding #14147

Closed
danyalprout opened this issue Jun 26, 2024 · 1 comment · Fixed by #14451
Closed

Invalid Blob Sidecars SSZ Encoding #14147

danyalprout opened this issue Jun 26, 2024 · 1 comment · Fixed by #14451
Labels
API Api related tasks Bug Something isn't working Deneb PRs or issues for the Deneb upgrade Need-Info Need more information from author

Comments

@danyalprout
Copy link

danyalprout commented Jun 26, 2024

Describe the bug

Hi 👋

It appears that when you make a /eth/v1/beacon/blob_sidecars/<slot> request to Prysm it prefixes the response with an additional four bytes (I'm assuming this is an non standard offset).

I believe this is specific to Prysm and other CL clients don't do this -- I've personally verified Lighthouse and this issue, mentions testing Nimbus & Teku too.

Attached the responses from Prysm and Lighthouse for slot 9378623 below:
lh-out-hex.txt
prysm-out-hex.txt

Has this worked before in a previous version?

I don't believe so.

🔬 Minimal Reproduction

  1. Fetch the data from Prysm curl -H "Accept: application/octet-stream;q=1,application/json;q=0.9" "https://prysm-url/eth/v1/beacon/blob_sidecars/9378623" > prysm-out
  2. Fetch the data from another CL client (e.g. Lighthouse) curl -H "Accept: application/octet-stream;q=1,application/json;q=0.9" "lh-url/eth/v1/beacon/blob_sidecars/5302905" > lh-out
  3. Convert the responses to hex xxd lh-out > lh-out.hex && xxd prysm-out > prysm-out.hex
  4. Diff the responses, see the leading four bytes 0400 0000

Error

No response

Platform(s)

Linux (x86)

What version of Prysm are you running? (Which release)

Prysm/v5.0.3

Anything else relevant (validator index / public key)?

No response

@danyalprout danyalprout added the Bug Something isn't working label Jun 26, 2024
@nisdas
Copy link
Member

nisdas commented Jun 26, 2024

Thanks for the report @danyalprout , have you been able to run v5.0.4 to see if it is still an issue ? We have had a few fixes for the blob sidecars endpoint

@nisdas nisdas added Deneb PRs or issues for the Deneb upgrade API Api related tasks labels Jun 26, 2024
@james-prysm james-prysm added the Need-Info Need more information from author label Sep 12, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Api related tasks Bug Something isn't working Deneb PRs or issues for the Deneb upgrade Need-Info Need more information from author
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants