Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github downloads are horribly slow and unreliable #3760

Closed
peabee opened this issue Dec 19, 2022 · 6 comments
Closed

Github downloads are horribly slow and unreliable #3760

peabee opened this issue Dec 19, 2022 · 6 comments

Comments

@peabee
Copy link
Contributor

peabee commented Dec 19, 2022

Frustration........
Release .zips are humongous and take forever to download and then frequently refuse to open......
Maybe release artefacts could be individual files rather than combined in huge .zip??

@dimkr
Copy link
Contributor

dimkr commented Dec 19, 2022

When build artifacts (*.iso and *.sfs) are uploaded, they're automatically joined into a single .zip file. Wildcards are convenient, because some file names change (for example, the kernel sources SFS name) and different build configurations produce different sets of files (for example, some don't produce devx or docx).

It is possible to upload the build artifacts separately, one-by-one, but somebody needs to write the logic that checks if a file exists, for every possible output file (kernel sources, devx, docx, nlsx, ISO, ...) and handle every possible corner case (for example, some ISO images have a -docx-nlsx.iso suffix).

@lakshayrohila
Copy link
Contributor

lakshayrohila commented Dec 19, 2022

Frustration........ Release .zips are humongous and take forever to download and then frequently refuse to open...... Maybe release artefacts could be individual files rather than combined in huge .zip??

Currently the user can click the Upload Release checkbox while running the github action. All the files then would be non-merged + SHA512 checksum file will also be provided. The release hence generated would be a draft. Then, if you're unsatisfied with the result, you can delete the draft release.

@dimkr
Copy link
Contributor

dimkr commented Dec 19, 2022

And don't forget that builds artifacts are not supposed to be user-friendly, they're supposed to be machine-friendly. This .zip file simplifies release.yml, which downloads a single file (the .zip file) and creates a release with all files inside it.

@peabee
Copy link
Contributor Author

peabee commented Dec 20, 2022

Currently the user can click the Upload Release checkbox while running the github action.

Thanks.

@peabee peabee closed this as completed Dec 20, 2022
@lakshayrohila
Copy link
Contributor

I have modified the "Building Puppy On Github" wiki page to allow the users to understand more about when to check upload release button and when not to. Here is the comparison.

@dimkr
Copy link
Contributor

dimkr commented Dec 23, 2022

The wording is inaccurate. I implemented the draft release checkbox because unlike draft releases, build artifacts are deleted automatically after a day, making it more convenient to leave it unchecked if it's a build you want to download yourself but don't intend to publish in a release. And if you do want to publish a new release, you can enable this option, download the draft release, test it, then publish the release or discard it if it's not ready for release. 90% of users of this action would want to download the build output, but I wouldn't recommend using this option unless you really intend to publish a release, because it's easy to forget a draft release behind and waste space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants