Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential css issue #451

Closed
lwasser opened this issue Jul 31, 2024 · 3 comments
Closed

Potential css issue #451

lwasser opened this issue Jul 31, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@lwasser
Copy link
Member

lwasser commented Jul 31, 2024

a while back @sneakers-the-rat mentioned adding some flex box items for our community page listing:

the bars get a lil big on mobile, how hard would it be to swap out a dropdown for small screens? Also if you throw a display: flex; > flex-wrap: wrap on the button container and a flex-grow: 1 on the children they fill the horizontal space nicely :)

Jonny - is this still an issue on larger screens? i don't see it on my screen but if you still think it's an issue we can keep this open.
i just made some changes to the css but this is one item i've had in my list for a while. Please let me know if we can close this OR if there is still an issue on larger screen a pr is welcome! thank you!

@lwasser lwasser added the bug Something isn't working label Jul 31, 2024
@sneakers-the-rat
Copy link
Contributor

i'll PR in a bit :)

@lwasser
Copy link
Member Author

lwasser commented Aug 1, 2024

thank you -- @sneakers-the-rat i wondered if you had time to look at our top nav styles. the search icon is now off the screen. i can try to manually position it but i wondered if there is some way to ensure it just always sits next to the hamburger for the nav menu? i feel like i fix one thing and then i break something else with it.

Screenshot 2024-08-01 at 9 37 50 AM

@lwasser
Copy link
Member Author

lwasser commented Aug 1, 2024

Because this was addressed I will close it!! Thank you for the pr!!

Opened a new issue for the search icon issues.

@lwasser lwasser closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants