Pyreverse: Duplicated class variables

[Franco0700]

Bug description

from typing import Optional

class ExampleClass():
    example1 : Optional[int] = None
    example2 : Optional[int] = None
    def __init__(self):
        self.example1 = 1
        self.example2 = 2

Configuration

No response

Command used

pyreverse -o plantuml toy_code.py

Pylint output

@startuml classes_toy_code
set namespaceSeparator none
class "ExampleClass" as parser.toy_code.ExampleClass {
  example1 : Optional[int]
  example1 : int
  example2 : Optional[int]
  example2 : int
}
@enduml

Expected behavior

@startuml classes_toy_code
set namespaceSeparator none
class "ExampleClass" as parser.toy_code.ExampleClass {
  example1 : Optional[int]
  example2 : Optional[int]
}
@enduml

Pylint version

pylint 2.16.0-dev
astroid 2.12.13
Python 3.10.8 (main, Nov  1 2022, 14:18:21) [GCC 12.2.0]

OS / Environment

5.15.85-1-MANJARO

Additional dependencies

No response

[nickdrozd]

A slightly simpler reproducing example:

class ExampleClass():
    example1: int
    example2: int

    def __init__(self):
        self.example1 = 1
        self.example2 = 2

Output:

@startuml classes
set namespaceSeparator none
class "ExampleClass" as asdf.ExampleClass {
  example1 : int
  example1 : int
  example2 : int
  example2 : int
}
@enduml

It seems like it doesn't understand the difference between declaration and assignment.

[DudeNr33]

There is a subtle difference between the original example and the new one.

In the original example, you have both class attributes example1 and example2 with value None, and instance attributes example1 and example2 with integer values.
Those exist independently from each other, and you can access both values for example1 from a class instance (through a classmethod or via instance.__class__.example1).

So the original example comes down to differentiating class attributes from instance attributes.
Looking at static features in UML and the example for SearchService.createEngine here the correct way would be to show the class attribute with an underline and the instance attribute without.

For your (@nickdrozd) example there should only be an instance attribute.

[dgutson]

Let's track both bugs on two separate issues? Or the root cause is the same?

[DudeNr33]

I created a new issue for Nick's example:
#8189

I also changed the label for this issue from Bug to Enhancement, as it is more fitting I think.