From 57c1cf603e13d9aeeea136c7e6160c7c0e07aae1 Mon Sep 17 00:00:00 2001 From: Andrew Murray Date: Sat, 7 Oct 2023 01:15:04 +1100 Subject: [PATCH 1/3] Fixed may be used uninitialized warning --- src/_imaging.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/_imaging.c b/src/_imaging.c index 7d75f4131b5..3ca1a7ac0ad 100644 --- a/src/_imaging.c +++ b/src/_imaging.c @@ -1575,11 +1575,7 @@ if (PySequence_Check(op)) { \ } double value; if (image->bands == 1) { - int bigendian; - if (image->type == IMAGING_TYPE_SPECIAL) { - // I;16* - bigendian = strcmp(image->mode, "I;16B") == 0; - } + int bigendian = image->type == IMAGING_TYPE_SPECIAL && strcmp(image->mode, "I;16B") == 0; for (i = x = y = 0; i < n; i++) { set_value_to_item(seq, i); if (scale != 1.0 || offset != 0.0) { From d9283fd1f8e57a3898688a8e3ab8aae8da23ddf8 Mon Sep 17 00:00:00 2001 From: Andrew Murray <3112309+radarhere@users.noreply.github.com> Date: Sat, 7 Oct 2023 17:09:17 +1100 Subject: [PATCH 2/3] Use default value Co-authored-by: Alexander Karpinsky --- src/_imaging.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/_imaging.c b/src/_imaging.c index 3ca1a7ac0ad..df1d242f366 100644 --- a/src/_imaging.c +++ b/src/_imaging.c @@ -1575,7 +1575,10 @@ if (PySequence_Check(op)) { \ } double value; if (image->bands == 1) { - int bigendian = image->type == IMAGING_TYPE_SPECIAL && strcmp(image->mode, "I;16B") == 0; + int bigendian = 0; + if (image->type == IMAGING_TYPE_SPECIAL) { + bigendian = strcmp(image->mode, "I;16B") == 0; + } for (i = x = y = 0; i < n; i++) { set_value_to_item(seq, i); if (scale != 1.0 || offset != 0.0) { From ceca12e8764371a87888de5f42d7a1e0ce3fb4a5 Mon Sep 17 00:00:00 2001 From: Andrew Murray <3112309+radarhere@users.noreply.github.com> Date: Sat, 7 Oct 2023 07:00:29 +0000 Subject: [PATCH 3/3] Restored comment --- src/_imaging.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/_imaging.c b/src/_imaging.c index df1d242f366..2270c77fe7e 100644 --- a/src/_imaging.c +++ b/src/_imaging.c @@ -1577,6 +1577,7 @@ if (PySequence_Check(op)) { \ if (image->bands == 1) { int bigendian = 0; if (image->type == IMAGING_TYPE_SPECIAL) { + // I;16* bigendian = strcmp(image->mode, "I;16B") == 0; } for (i = x = y = 0; i < n; i++) {