From 6797e47458177020877bf1efa3bed230e0db6d69 Mon Sep 17 00:00:00 2001 From: Hugo van Kemenade Date: Sat, 8 Apr 2023 19:52:04 +0300 Subject: [PATCH 1/2] Add release check to make sure no TODOs remain in release notes --- Makefile | 1 + Tests/check_release_notes.py | 6 ++++++ 2 files changed, 7 insertions(+) create mode 100644 Tests/check_release_notes.py diff --git a/Makefile b/Makefile index f51325d474b..e41f3641108 100644 --- a/Makefile +++ b/Makefile @@ -78,6 +78,7 @@ debug: .PHONY: release-test release-test: + python3 Tests/check_release_notes.py python3 -m pip install -e .[tests] python3 selftest.py python3 -m pytest Tests diff --git a/Tests/check_release_notes.py b/Tests/check_release_notes.py new file mode 100644 index 00000000000..db9ba364b1a --- /dev/null +++ b/Tests/check_release_notes.py @@ -0,0 +1,6 @@ +import sys +from pathlib import Path + +for rst in Path("docs/releasenotes/").rglob("[1-9]*.rst"): + if "TODO" in open(rst).read(): + sys.exit(f"Error: remove TODO from {rst}") From 80a1238e2bf5796145b4d976524a52c603bd53eb Mon Sep 17 00:00:00 2001 From: Hugo van Kemenade Date: Sun, 9 Apr 2023 22:43:36 +0300 Subject: [PATCH 2/2] Simplify glob Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com> --- Tests/check_release_notes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tests/check_release_notes.py b/Tests/check_release_notes.py index db9ba364b1a..0a9a898d7f7 100644 --- a/Tests/check_release_notes.py +++ b/Tests/check_release_notes.py @@ -1,6 +1,6 @@ import sys from pathlib import Path -for rst in Path("docs/releasenotes/").rglob("[1-9]*.rst"): +for rst in Path("docs/releasenotes").glob("[1-9]*.rst"): if "TODO" in open(rst).read(): sys.exit(f"Error: remove TODO from {rst}")