-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It seemed that the box of Draw.rectangle contained the end xy point #1668
Comments
Hi. While there is not a solution at present, you will be able to find some discussion about this problem in #367 |
Can we call this a duplicate of #367? |
I understand this is a bit of a complicated issue (given #367), but is that bug really safe to fix? I know I've written code that would break if But I'd like to fix the documentation separately from #367. After all, isn't documentation supposed to describe how software actually works, not how we wish it worked after we fixed all the bugs? Would anyone mind a change like this?
With a bunch of links added. |
I just got bitten by this. I don't think the behavior of draw.rectangle can be changed at this point; too much code surely depends on it working the way it currently does. So can we at least fix the docs so they aren't lying? |
I don't think the rectangle docs actually have much to do with #387. If you look at the code, you can see it's a very explicit choice (for whatever reason) to include the final y coordinate in the loop, and including the final x coordinate is a result of the code plus the way Line 759 in aa8877a
|
I learned this from doc:
Then I ran this script
The output was
It drew 9 points, while I just wanted the first 4 points to be filled
The text was updated successfully, but these errors were encountered: