-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change from constants to enums #5875
Labels
Comments
I think it's designed for casting int value from python to cpp conveniently, and validate it cpp :D |
I've created #5954 to resolve this. See what you think. |
Awesome work radarhere, left a review there! |
radarhere
changed the title
Feature request: change from constants to enums
Change from constants to enums
Jan 18, 2022
Be aware that #6684 has been proposed, which would revert the changes for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature request
Example set of constants that would fit into an enum really well:
https://pillow.readthedocs.io/en/stable/_modules/PIL/Image.html#Image.transpose
That could be refactored to:
Advantages:
Disadvantages:
Smaller factors:
The text was updated successfully, but these errors were encountered: