Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccmake issue when building Greedy on Linux #44

Open
neurolabusc opened this issue Dec 27, 2023 · 0 comments
Open

ccmake issue when building Greedy on Linux #44

neurolabusc opened this issue Dec 27, 2023 · 0 comments

Comments

@neurolabusc
Copy link

Thanks for the terrific tool.

The binary version of greedy provided with the latest Linux release of ITK snap (Greedy Version 1.3.0-alpha compiled on Sep 29, 2023) was compiled with a version of ITK that generates false alarms in ensuring orthonormal directions. Re-compiling greedy with a recent version of ITK resolves this issue (I installed the Github master ITK and VTK libraries).

However, I would like to suggest the following enhancements:

  • It would be great if the greedy (and ITK-SNAP) binaries were distributed with this fix.
  • The current version of greedy downloaded from the master branch requires VTK for quality mesh transformations. Since the Installation directions suggest downloading from the master branch, the Prerequisites of the Installation documents should be updated to reflect this requirement.
  • After installing VTK, the Installation directions did allow me to compile grredy, however the make command did not complete successfully. Presumably, it had issues compiling other executables using gcc version 13.2.0 (Ubuntu 13.2.0-4ubuntu3) . Perhaps additional instructions need to be added to the installation guide. These are the errors from the compile:
/home/chris/src/greedy/testing/src/greedy_multi_chunk.cxx: In function ‘void initialize_assemblies(ChunkGreedyParameters, GreedyParameters, std::map<short int, MultiChunkAffineAssembly<VDim, TReal> >&, std::vector<short int, std::allocator<short int> >&, typename itk::Image<short int, VDim>::Pointer&)’:
/home/chris/src/greedy/testing/src/greedy_multi_chunk.cxx:189:20: error: ‘BinaryThresholdImageFilter’ in namespace ‘itk’ does not name a template type
  189 |       typedef itk::BinaryThresholdImageFilter<ChunkMaskImageType, typename LDDMMType::ImageType> TFilter;
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/chris/src/greedy/testing/src/greedy_multi_chunk.cxx:190:16: error: ‘TFilter’ has not been declared
  190 |       typename TFilter::Pointer thresh = TFilter::New();
      |                ^~~~~~~
/home/chris/src/greedy/testing/src/greedy_multi_chunk.cxx:190:33: error: expected ‘(’ before ‘thresh’
  190 |       typename TFilter::Pointer thresh = TFilter::New();
      |                                 ^~~~~~
      |                                 (
/home/chris/src/greedy/testing/src/greedy_multi_chunk.cxx:191:7: error: ‘thresh’ was not declared in this scope
  191 |       thresh->SetInput(chunk_mask);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant