Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify Questionmark-specific barcodes by implementing #questionmark? #17

Open
Narnach opened this issue Nov 11, 2022 · 1 comment
Open

Comments

@Narnach
Copy link
Collaborator

Narnach commented Nov 11, 2022

Questionmark's internal systems currently check if a barcode is prefixed with 9669 to see if it's a QM-specific dummy barcode or if it's an official GTIN.

It's cleaner to have all parsed GTINs respond to #questionmark? and have the default ones return false while "ours" return true.

@Narnach Narnach mentioned this issue Nov 11, 2022
7 tasks
@wvengen
Copy link
Member

wvengen commented Nov 16, 2022

Ah yes, that's a great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants