Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wan2skeaf.jl is creating unnecessary bxsf files that are then stored in AiiDA database as RemoteData nodes #8

Open
npaulish opened this issue Jun 4, 2024 · 0 comments

Comments

@npaulish
Copy link
Contributor

npaulish commented Jun 4, 2024

When separating the initial bxsf into single band files for SKEAF, it would be more efficient to write only the ones that are necessary (only for the bands that cross Fermi energy)

  • Make sure to pass the user defined Fermi energy from the SKEAF parameters and decide accordingly which files to write

Important: If custom Fermi energy needs to be passed both to Wan2skeafCalculation and SkeafCalculation it should be an input to the workchain. Otherwise, e.g. if someone specifies a shifted Fermi energy only for SKEAF, wan2skeaf writes the bxsf files for only for the bands that cross the original Fermi level and the resulting frequencies will miss the contribution from the other bands crossing the new Fermi level.

@npaulish npaulish changed the title Write bxsfs only for the bands that cross the Fermi energy Wan2skeaf.jl is creating unnecessary bxsf files that are then stored in AiiDA database as RemoteData nodes Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant