Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspelling of the world "Collisions" in context.go comment #1189

Closed
swam92 opened this issue Mar 14, 2020 · 5 comments
Closed

Fix misspelling of the world "Collisions" in context.go comment #1189

swam92 opened this issue Mar 14, 2020 · 5 comments
Labels
good first issue sink your teeth into open source!

Comments

@swam92
Copy link

swam92 commented Mar 14, 2020

There is a minor misspelling in the source file qri/api/context.go. The word "collissions" on line 14 should be changed to "collisions".

@dustmop dustmop added the good first issue sink your teeth into open source! label Mar 16, 2020
@swam92
Copy link
Author

swam92 commented Mar 17, 2020

@dustmop Thanks. I have opened up a branch locally named 1189-fix-spelling-of-collisions that addresses this change, but when I run "git push origin 1189-fix-spelling-of-collisions" I get the following message :

remote: Permission to qri-io/qri.git denied to swam92.
fatal: unable to access 'https://github.com/qri-io/qri.git/': The requested URL returned error: 403

Is there something I am missing that is required to push remotely/open pull requests?

@dustmop
Copy link
Contributor

dustmop commented Mar 17, 2020

By default, users can't push commits to repositories that they don't have write access to. In order to create a Pull Request, you'll need to fork the repository and push to your own fork. Check out these links for more information:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork
https://gist.github.com/Chaser324/ce0505fbed06b947d962

Looking forward to your Pull Request, thanks!

@sesam
Copy link

sesam commented Oct 7, 2020

@swam92 Hey, where have you gone? :)

@jcardoz
Copy link

jcardoz commented Oct 19, 2020

@sesam - I can take this up

@dustmop
Copy link
Contributor

dustmop commented Oct 19, 2020

This has already been fixed, by #1561

@dustmop dustmop closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue sink your teeth into open source!
Projects
None yet
Development

No branches or pull requests

4 participants