Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default numbers don't fit in cells #1468

Closed
luke-quadratic opened this issue Jun 25, 2024 · 1 comment · Fixed by #1526
Closed

Default numbers don't fit in cells #1468

luke-quadratic opened this issue Jun 25, 2024 · 1 comment · Fixed by #1526
Assignees
Labels
type: enhancement new feature or request type: papercut annoying but not the end of the world

Comments

@luke-quadratic
Copy link
Contributor

Image

@luke-quadratic luke-quadratic added the type: papercut annoying but not the end of the world label Jun 25, 2024
@davidfig
Copy link
Collaborator

davidfig commented Jul 2, 2024

This is a bit complicated. We'll have to move the number rendering (ie, determining what the string of the number looks like from its options and values) from Rust to TS, since we'll need to adjust how it's displayed based on its actual rendering size, which we can only calculate while rendering.

I started prototyping this work, but I'd rather wait until #1406 (vertical wrapping) is merged, as I'l touch similar files to that one.

@davidfig davidfig added the type: enhancement new feature or request label Jul 2, 2024
@davidfig davidfig self-assigned this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement new feature or request type: papercut annoying but not the end of the world
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants