Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive Messaging (RabbitMQ) health check cannot be disabled #31977

Closed
jdussouillez opened this issue Mar 20, 2023 · 5 comments
Closed

Reactive Messaging (RabbitMQ) health check cannot be disabled #31977

jdussouillez opened this issue Mar 20, 2023 · 5 comments

Comments

@jdussouillez
Copy link

jdussouillez commented Mar 20, 2023

Describe the bug

RabbitMQ reactive messaging health check cannot be disabled using health-enabled. It seems the option has no effect and health check are still enabled if I look in the Dev UI.

Configuration :

# ...
mp.messaging.outgoing.quote-requests.health-enabled=false
mp.messaging.outgoing.quote-requests.health-readiness-enabled=false

# ...
mp.messaging.incoming.quotes.health-enabled=false
mp.messaging.incoming.quotes.health-readiness-enabled=false

health_enabled

These checks are disabled if I use quarkus.health.extensions.enabled but I want to keep some checks on other extensions.

Expected behavior

The following health check must be disabled:

  • "SmallRye Reactive Messaging - liveness check"
  • "SmallRye Reactive Messaging - readiness check"
  • "SmallRye Reactive Messaging - startup check"

Actual behavior

The heath checks are still enabled.

How to Reproduce?

Output of uname -a or ver

Linux 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Output of java -version

openjdk version "17.0.6" 2023-01-17 OpenJDK Runtime Environment (build 17.0.6+10-Ubuntu-0ubuntu120.04.1) OpenJDK 64-Bit Server VM (build 17.0.6+10-Ubuntu-0ubuntu120.04.1, mixed mode, sharing)

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.16.4.Final

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) Maven home: ~/.m2/wrapper/dists/apache-maven-3.8.6-bin/67568434/apache-maven-3.8.6 Java version: 17.0.6, vendor: Private Build, runtime: /usr/lib/jvm/java-17-openjdk-amd64 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.4.0-144-generic", arch: "amd64", family: "unix"

Additional information

No response

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 20, 2023

/cc @cescoffier (reactive-messaging), @jmartisk (health), @ozangunalp (reactive-messaging), @xstefank (health)

@jdussouillez
Copy link
Author

Might be related to #15321

@jdussouillez
Copy link
Author

jdussouillez commented May 23, 2023

This is still happing with Quarkus 3.0.3.Final. https://github.com/jdussouillez/quarkus-rabbitmq-health-check/tree/v3

@cescoffier cescoffier changed the title RabbitMQ reactive messaging health check cannot be disabled Reactive Messaging (RabbitMQ) health check cannot be disabled Aug 28, 2023
@cescoffier
Copy link
Member

@ozangunalp can't we close this issue?

@ozangunalp
Copy link
Contributor

Yes, this is resolved in reactive messaging 4.14.0 and is now used by Quarkus main. Per channel health checks are documented in https://smallrye.io/smallrye-reactive-messaging/latest/rabbitmq/rabbitmq-health/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants