Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate ad-hoc signed JAR in JarResultBuildStepTest #40156

Closed
gastaldi opened this issue Apr 19, 2024 · 5 comments · Fixed by #41494
Closed

Generate ad-hoc signed JAR in JarResultBuildStepTest #40156

gastaldi opened this issue Apr 19, 2024 · 5 comments · Fixed by #41494
Labels
area/core good first issue Good for newcomers kind/enhancement New feature or request
Milestone

Comments

@gastaldi
Copy link
Contributor

In #40001 we're using the dependency plugin to download an already signed JAR to run the JarResultBuildStepTest. It would be nice if we could create one on the fly if possible (with Shrinkwrap?) and then sign it with some randomly generated keys.

Originally posted by @galderz in #40001 (comment)

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 19, 2024

/cc @Sanne (core), @aloubyansky (core), @geoand (core), @gsmet (core), @radcortez (core), @stuartwdouglas (core)

@DShivansh
Copy link
Contributor

Hey @gastaldi
I was thinking of picking this issue so far I have figured out how to make a jar using shrinkwarp but I am not sure how to sign the jar programmatically do you have any suggestions on this.

@DShivansh
Copy link
Contributor

Hi @galderz
I saw your comment -> #40001 (comment)
I was just wondering whether we can use bouncycastle as I could not find any other way to generate certificate on the fly.

@galderz
Copy link
Member

galderz commented Jun 24, 2024

@DShivansh That's probably fine, just add it as a test dependency.

@DShivansh
Copy link
Contributor

@galderz @gastaldi can you please review the pr

@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants