Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maven 4] Get rid of ${maven.multiModuleProjectDirectory} #42430

Open
gsmet opened this issue Aug 8, 2024 · 5 comments · May be fixed by #42440
Open

[Maven 4] Get rid of ${maven.multiModuleProjectDirectory} #42430

gsmet opened this issue Aug 8, 2024 · 5 comments · May be fixed by #42440
Assignees

Comments

@gsmet
Copy link
Member

gsmet commented Aug 8, 2024

This was apparently an internal property and it got removed from mvnd.

We put a hack in place here: #41648 but we should get rid of it and use ${session.rootDirectory} instead.

This property was introduced in https://issues.apache.org/jira/browse/MNG-7038 and has been backported to 3.9.2: https://maven.apache.org/docs/3.9.2/release-notes.html .

@gsmet gsmet self-assigned this Aug 8, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 8, 2024

/cc @quarkusio/devtools (maven)

@maxandersen
Copy link
Contributor

this just affects quarkus own build, right ? as this would mean mvn as found on rhel/ubi 8 wouldn't be able to build I reckon.

@gsmet
Copy link
Member Author

gsmet commented Aug 9, 2024

Yes.

@gsmet
Copy link
Member Author

gsmet commented Aug 9, 2024

Actually, the situation is a bit more complex than that, I should have read the fine prints of the 3.9.2 release notes.

While these properties are available across the board in Maven 4, in Maven 3.9, they are restricted to the Maven config, they are not usable in a POM file:

It is important to mention, that those two new properties, are only working within the maven.config file and via the command line. They are NOT usable as configuration properties within your plugin configuration in your pom.xml file.

We will have to wait for Maven 4 before cleaning this up.

@gsmet gsmet changed the title Get rid of ${maven.multiModuleProjectDirectory} [Maven 4] Get rid of ${maven.multiModuleProjectDirectory} Aug 9, 2024
@manofthepeace
Copy link
Contributor

Yes, this is why we went with the hack in the current solution, and not simply doing the "replace all"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants