From b5d23a864759d2d5ba819d70e30f9c87ef6784db Mon Sep 17 00:00:00 2001 From: link2xt Date: Thu, 30 Nov 2023 19:59:15 +0000 Subject: [PATCH] Remove "max_tlps" configuration variable It is not used since (commit bdc9ac76a453208848a58bf3b24a633ade8b299a) was merged in 2018. RFC 9002 also does not mention Tail Loss Probe except that it has been integrated into the PTO (Probe Timeout) mechanism. --- quinn-proto/src/config.rs | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/quinn-proto/src/config.rs b/quinn-proto/src/config.rs index d5483ed50..538a97b0e 100644 --- a/quinn-proto/src/config.rs +++ b/quinn-proto/src/config.rs @@ -32,7 +32,6 @@ pub struct TransportConfig { pub(crate) receive_window: VarInt, pub(crate) send_window: u64, - pub(crate) max_tlps: u32, pub(crate) packet_threshold: u32, pub(crate) time_threshold: f32, pub(crate) initial_rtt: Duration, @@ -135,12 +134,6 @@ impl TransportConfig { self } - /// Maximum number of tail loss probes before an RTO fires. - pub fn max_tlps(&mut self, value: u32) -> &mut Self { - self.max_tlps = value; - self - } - /// Maximum reordering in packet number space before FACK style loss detection considers a /// packet lost. Should not be less than 3, per RFC5681. pub fn packet_threshold(&mut self, value: u32) -> &mut Self { @@ -331,7 +324,6 @@ impl Default for TransportConfig { receive_window: VarInt::MAX, send_window: (8 * STREAM_RWND).into(), - max_tlps: 2, packet_threshold: 3, time_threshold: 9.0 / 8.0, initial_rtt: Duration::from_millis(333), // per spec, intentionally distinct from EXPECTED_RTT @@ -365,7 +357,6 @@ impl fmt::Debug for TransportConfig { stream_receive_window, receive_window, send_window, - max_tlps, packet_threshold, time_threshold, initial_rtt, @@ -391,7 +382,6 @@ impl fmt::Debug for TransportConfig { .field("stream_receive_window", stream_receive_window) .field("receive_window", receive_window) .field("send_window", send_window) - .field("max_tlps", max_tlps) .field("packet_threshold", packet_threshold) .field("time_threshold", time_threshold) .field("initial_rtt", initial_rtt)