Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Map loading errors introduced in 0.9 #193

Closed
klevo opened this issue May 30, 2024 · 3 comments
Closed

Source Map loading errors introduced in 0.9 #193

klevo opened this issue May 30, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@klevo
Copy link

klevo commented May 30, 2024

After upgrading to v0.9, in Safari one can observe "Source Map loading errors" immediately. In other browsers, like Chrome, after going to Sources and selecting for example stimulus.min-xxx.js there is a source map loading error as well.

This can be easily replicated with a new vanilla Rails app:

rails new --asset-pipeline=propshaft rails-with-propshaft
cd rails-with-propshaft
bin/setup
rails g scaffold Message title:string
rails db:migrate
bin/dev

Then navigate to http://localhost:3000/messages and open up the JS console.
safari error
chrome error

@theodorton theodorton self-assigned this May 30, 2024
@theodorton theodorton added the bug Something isn't working label May 30, 2024
@theodorton
Copy link
Collaborator

Could you test with your project to confirm that the issue is resolved in #194?

gem 'propshaft', github: 'rails/propshaft', branch: 'fix-source-map-404'

@klevo
Copy link
Author

klevo commented May 31, 2024

Great job @theodorton - I can confirm that fixed it 🎉

@klevo
Copy link
Author

klevo commented Jun 5, 2024

I see the fix has been merged. I'm closing the issue. Thanks!

@klevo klevo closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants