Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Unique IDs #1

Open
dephora opened this issue Jul 9, 2017 · 2 comments
Open

Request: Unique IDs #1

dephora opened this issue Jul 9, 2017 · 2 comments

Comments

@dephora
Copy link

dephora commented Jul 9, 2017

Hi there, really appreciate the addon.

I'm using it in a list of components, any of which can be open at any given time, so it immediately breaks once more than one is open since the id is already in use. It would be useful if the addon appended an unique identifier to the the IDs to prevent this.

@rajasegar
Copy link
Owner

@dephora The relationship between the navigation components and the tab-pane component is done by the paneId and elementId properties which should be exactly the same for the matching to happen.
I am not very sure how we can use Unique Ids in this case and make them work.
Anyhow i will explore some more about the feasibility of this approach and let you know.

For now, the workaround will be if you have multiple tab components in the same, we need to give unique ids for both the paneId and elementId. Please refer to the dummy application for reference.

@dephora
Copy link
Author

dephora commented Jul 10, 2017

@rajasegar Okay, yeah for now I'm just going to append the parent component ember ID to each pane / element ID. I imagine the simplest method will consist of creating an empty array and just adding to that for each instance of the set of tabs created with the option of 'uniqueIDs' or whatever passed in. I'll look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants