Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support standard OIDC birthdate claim #119

Closed
alex-swift opened this issue Jul 11, 2023 · 4 comments
Closed

Support standard OIDC birthdate claim #119

alex-swift opened this issue Jul 11, 2023 · 4 comments

Comments

@alex-swift
Copy link
Contributor

OpenID Connect Core defines the list of the standard claims https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims. One of these claims is birthdate.

StandardClaims structure supports birthday, but does not support birthdate:
@see

pub(crate) birthday: Option<EndUserBirthday>,

Could you please add support for birthdate claim or rename birthday by birthdate?

@ramosbugs
Copy link
Owner

ah shoot this looks like a typo. nice catch!

to avoid introducing a breaking change in case anyone depends on birthday, I think we'll need to add birthdate (of existing type EndUserBirthday) rather than rename birthday. I'm not sure when I'll have time to do this, but I would be happy to merge a PR that does this (with test coverage that adds the field to existing tests).

@alex-swift
Copy link
Contributor Author

@ramosbugs, please review #120

@alex-swift
Copy link
Contributor Author

Thank you for quick response.

@ramosbugs
Copy link
Owner

This is now fixed in 3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants