Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One EKS cluster not clickable in the UI #10043

Closed
gaktive opened this issue Nov 16, 2023 · 4 comments · Fixed by #10366
Closed

One EKS cluster not clickable in the UI #10043

gaktive opened this issue Nov 16, 2023 · 4 comments · Fixed by #10366
Assignees
Labels
JIRA kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this size/3 Size Estimate 3
Milestone

Comments

@gaktive
Copy link
Member

gaktive commented Nov 16, 2023

Internal reference: SURE-7035
Reported in 2.7.6

Issue description:
The cluster EKS eks-entsvcs-pci-dev (cluster ID: c-nqdv4) is not clickable from the explorer after Rancher upgrade from 2.6.12 to 2.7.6

Business impact:
The user can't click on that cluster from the explorer

Troubleshooting steps:
reviewed the rancher pods and cluster agent logs
rolling restart of rancher pods
re-deployed the cluster agents

Repro steps:
Support was not able to reproduce it, but the user wants to know what is causing this behavior

Workaround:
None

Using the cluster management or directly accessing the link for that cluster with something like this https://hostname/dashboard/c/c-xxxxx/explorer

Actual behavior:
A cluster is not clickable from the explorer

Expected behavior:
A cluster should be and clickable when it is Active in Rancher

Addenda:

  • Logs & HAR files available via the SURE ID.
@realhuseyn
Copy link

Any updates? I have faced this issue

@gaktive gaktive added size/3 Size Estimate 3 [zube]: Groomed and removed [zube]: Backlog labels Dec 13, 2023
@aalves08
Copy link
Member

aalves08 commented Dec 19, 2023

Going through the code in 2.7.6 and checking the objects provided in the JSON and HAR files for both the management and provisioning clusters, the homepage and side menu links are disabled because the management object has a condition with error: true there which is needed for enabling the homepage link

Check for main nav link:
x.isReady && !pCluster?.hasError where x is of type management cluster => fails because prov cluster has a status.condition with error: true => side menu https://github.com/rancher/dashboard/blob/release-2.7.6/shell/models/provisioning.cattle.io.cluster.js#L863-L865. 🛑 fails on pCluster.hasError

Check for homepage link:
row.mgmt.isReady && !row.hasError where row is of type provisioning cluster => fails because prov cluster has a status.condition with error: true => side menu https://github.com/rancher/dashboard/blob/release-2.7.6/shell/models/provisioning.cattle.io.cluster.js#L863-L865. 🛑 fails on row.hasError

check for /explorer route direct access:
!cluster.isReady where cluster is of type management cluster => works because it has a Connected condition ✅

https://github.com/rancher/dashboard/blob/release-2.7.6/shell/models/management.cattle.io.cluster.js#L173-L181
https://github.com/rancher/dashboard/blob/release-2.7.6/shell/models/provisioning.cattle.io.cluster.js#L863-L865

The workaround (direct link to /explorer) works because the authenticated middleware is just checking for isReady on
the store action loadCluster for the management cluster https://github.com/rancher/dashboard/blob/release-2.7.6/shell/models/management.cattle.io.cluster.js#L173-L181, which in turn has the correct checks for it to work.

The question here is: which is correct set of condition for us to check for both links?

FYI @nwmac @richard-cox

@aalves08
Copy link
Member

aalves08 commented Jan 8, 2024

The explore button on Cluster Managament should also be disabled since:

row.mgmt && row.mgmt.isReady && !row.hasError where row is of type provisioning cluster=> fails because prov cluster has a status.condition with error: true => side menu https://github.com/rancher/dashboard/blob/release-2.7.6/shell/models/provisioning.cattle.io.cluster.js#L863-L865. 🛑 fails on row.hasError

@izaac
Copy link
Contributor

izaac commented Feb 15, 2024

@yonasberhe23 the test coverage looks good to me, the scenario is really hard to reproduce for a manual validation after going through the issue comments. We can move to done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JIRA kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this size/3 Size Estimate 3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants