Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKS: Nodepool name field needs validation for unsupported format #10462

Closed
cpinjani opened this issue Feb 15, 2024 · 2 comments · Fixed by #10712
Closed

AKS: Nodepool name field needs validation for unsupported format #10462

cpinjani opened this issue Feb 15, 2024 · 2 comments · Fixed by #10712
Assignees
Labels
area/aks kind/bug QA/manual-test Indicates issue requires manually testing team/highlander Highlander
Milestone

Comments

@cpinjani
Copy link

Setup
Rancher version: v2.9-a9534addc5745ec2c93cde7f5e3c54bc9b3a1f91-head
Browser type & version: Chrome latest

Describe the bug
AKS Nodepool name field needs validation for unsupported format. This validation was present on old UI, but missing on new UI.

To Reproduce

  • Create downstream AKS cluster
  • Provide nodepool name in unsupported format eg. agentPool

Screenshots
2.8:
image

2.9 allows cluster creation which eventually fails:
image

@valaparthvi
Copy link

Validated on Rancher(v2.9-a9355940c0629ca419b7dd3e4098c4ea0e52c0c0-head); Dashboard(master 46a44c1), it is partially fixed.

  • There is validation for unsupported characters.
    Screenshot from 2024-07-10 15-15-34

  • There is no inline validation for unsupported length, even though the creation fails later on with error:

 Error failed to create cluster: PUT https://management.azure.com/subscriptions/80de5134-ca65-4731-be21-13fb1f0910a2/resourceGroups/pvala-aks-rg/providers/Microsoft.ContainerService/managedClusters/pvala-aks-invalid-np-name -------------------------------------------------------------------------------- RESPONSE 400: 400 Bad Request ERROR CODE: InvalidParameter -------------------------------------------------------------------------------- { "code": "InvalidParameter", "details": null, "message": "The value of parameter agentPoolProfile.name is invalid. Please see https://aka.ms/aks-naming-rules for more details.", "subcode": "", "target": "agentPoolProfile.name" } -------------------------------------------------------------------------------- 

image

@mantis-toboggan-md
Copy link
Member

@valaparthvi I'd like to track adding node pool name length validation with #11405 and keep this ticket for the invalid character issue if that works for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/aks kind/bug QA/manual-test Indicates issue requires manually testing team/highlander Highlander
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants