Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: Convert the various creators into a single creator #11484

Closed
aalves08 opened this issue Jul 18, 2024 · 2 comments · Fixed by #11605
Closed

Extensions: Convert the various creators into a single creator #11484

aalves08 opened this issue Jul 18, 2024 · 2 comments · Fixed by #11605
Assignees
Labels
area/extensions kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@aalves08
Copy link
Member

aalves08 commented Jul 18, 2024

Is your feature request related to a problem? Please describe.

Convert the various creators into a single creator package/lib.

We currently have:
skeleton app creation: https://github.com/rancher/dashboard/tree/master/shell/creators/app
extension/package creation: https://github.com/rancher/dashboard/tree/master/shell/creators/pkg
extension update: https://github.com/rancher/dashboard/tree/master/shell/creators/update

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Suggestion:

create a new folder for your code
yarn create @rancher/extension EXTENSION_NAME

Operates a bit more intelligently.

So looks to see if there is an app, if not, it creates one then it creates the extension.
If there is, it adds the extension.
app name and extension name would be the same - maybe an arg to give a different app name
Maybe an arg to only create an app

@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jul 18, 2024
@jordojordo jordojordo self-assigned this Aug 7, 2024
@jordojordo jordojordo added this to the v2.10.0 milestone Aug 7, 2024
@izaac izaac self-assigned this Aug 22, 2024
@izaac
Copy link
Contributor

izaac commented Aug 26, 2024

@yonasberhe23 this seems to be only configuration updates and tooling, looks good to close to me. Thoughts?

@izaac
Copy link
Contributor

izaac commented Aug 27, 2024

Moving to done

@izaac izaac closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extensions kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants