Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm App Upgrade: Add support for new label on ClusterRepo to help when identifying source repository for updates #11675

Open
nwmac opened this issue Aug 21, 2024 · 0 comments
Assignees
Labels
area/apps kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@nwmac
Copy link
Member

nwmac commented Aug 21, 2024

EPIC: #11465

Backend: rancher/rancher#45997

Goal:

In the UI code that tries to find the correct chart to use when suggesting an upgrade to an app for a user, we should use the ner label added by the backend team - this will help to avoid the situation where we show an upgrade from a different chart repository to the one the app was installed from.

This should be a case of updating matchingChart here - https://github.com/rancher/dashboard/blob/master/shell/models/catalog.cattle.io.app.js#L50

If we do NOT have the annotations, then we should look for the predered repo name from the new label (catalog.cattle.io/cluster-repo-name), if it is there, we use that and we use a prefered repo type of cluster.

@nwmac nwmac added this to the v2.10.0 milestone Aug 21, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Aug 21, 2024
@nwmac nwmac added area/apps JIRA and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this JIRA labels Aug 21, 2024
@nwmac nwmac changed the title Add support for new label on ClusterRepo to help when identifying source repository for updates Helm App Upgrade: Add support for new label on ClusterRepo to help when identifying source repository for updates Aug 22, 2024
@nwmac nwmac added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

No branches or pull requests

2 participants