Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm App Upgrade: Use more fields when trying to find the correct matching chart for an app #11679

Open
nwmac opened this issue Aug 22, 2024 · 0 comments
Assignees
Labels
kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@nwmac
Copy link
Member

nwmac commented Aug 22, 2024

EPIC: #11465

For Helm Apps, we attempt to find the chart for the app and then look to see if upgrades are available - if so, we indicate this to the user. A chart may exist in two (or more) Helm repositories. At the moment, we will just chose the first one, which means we might show an upgrade that the user probably doesn't want to make.

We should do a better job of finding the matching chart.

For reference, see: https://github.com/rancher/dashboard/blob/master/shell/models/catalog.cattle.io.app.js#L50

The store has a getter catalog/chart () - I suggest we add a new getter catalog/matchingCharts or alike that returns all of hte matching charts.

The code here - https://github.com/rancher/dashboard/blob/master/shell/models/catalog.cattle.io.app.js#L50 - should use that new getter AND if there are multiple charts returned, it should check the following additional chart metadata properties to get a better match if possible:

  • home
  • sources

If it finds a better match it should return that one - otherwise it should return the first, as it does today.

@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Aug 22, 2024
@nwmac nwmac added this to the v2.10.0 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

No branches or pull requests

2 participants