Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3: Failing Unit Tests #11682

Closed
33 tasks
rak-phillip opened this issue Aug 22, 2024 · 0 comments · Fixed by #11776
Closed
33 tasks

Vue3: Failing Unit Tests #11682

rak-phillip opened this issue Aug 22, 2024 · 0 comments · Fixed by #11776
Assignees
Labels
area/unit-test Issues involving need, configuration or changes of unit test area/vue3 kind/tech-debt Technical debt QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@rak-phillip
Copy link
Member

rak-phillip commented Aug 22, 2024

Several tests have failures after migrating to Vue3.

Offending tests (not fixed yet):

  • pkg/aks/components/tests/AksNodePool.test.ts
  • pkg/aks/components/tests/CruAks.test.ts
  • pkg/eks/components/tests/Config.test.ts
  • pkg/eks/components/tests/CruEKS.test.ts
  • pkg/eks/components/tests/Networking.test.ts
  • pkg/gke/components/tests/Config.test.ts
  • pkg/gke/components/tests/GKENodePool.test.ts
  • pkg/gke/components/tests/Networking.test.ts
  • shell/components/tests/ConsumptionGauge.test.ts
  • shell/components/tests/NamespaceFilter.test.ts
  • shell/components/form/tests/Command.test.ts
  • shell/components/form/tests/KeyValue.test.ts
  • shell/components/form/tests/Taints.test.ts
  • shell/components/nav/WindowManager/tests/ContainerShell.test.ts
  • shell/components/Questions/tests/Boolean.test.ts
  • shell/components/Questions/tests/Float.test.ts
  • shell/components/Questions/tests/Int.test.ts
  • shell/components/Questions/tests/String.test.ts
  • shell/components/Questions/tests/Yaml.test.ts
  • shell/detail/tests/autoscaling.horizontalpodautoscaler.test.ts
  • shell/edit/tests/service.test.ts
  • shell/edit/provisioning.cattle.io.cluster/tests/Basics.test.ts
  • shell/edit/provisioning.cattle.io.cluster/tabs/registries/tests/RegistryConfigs.test.ts
  • shell/edit/workload/tests/Job.test.ts
  • shell/pages/c/_cluster/longhorn/tests/longhorn.index.test.ts
  • shell/pages/c/_cluster/uiplugins/tests/AddExtensionRepos.test.ts
  • pkg/eks/components/tests/NodeGroup.test.ts
  • shell/edit/workload/storage/tests/Mount.test.ts
  • shell/edit/persistentvolume/tests/persistentvolume.test.ts
  • shell/edit/auth/tests/azuread.test.ts
  • shell/edit/tests/namespace.test.ts
  • shell/components/nav/WindowManager/tests/ContainerLogs.test.ts
  • shell/components/tests/CodeMirror.test.ts

Offending tests (fixed):

Acceptance Criteria

Offending tests pass by asserting similar behavior from Vue2.

Notes:

We're skipping failing tests to make the vue3 merge simpler/more pleasant for others to commit to. I've added an "annotation" (Vue3 Skip) to make it easy to find all the tests that were skipped while staying in the codebase.

Image

@rak-phillip rak-phillip added area/unit-test Issues involving need, configuration or changes of unit test area/vue3 labels Aug 22, 2024
@rak-phillip rak-phillip added this to the v2.10.0 milestone Aug 22, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Aug 22, 2024
@richard-cox richard-cox added the kind/tech-debt Technical debt label Aug 23, 2024
@mantis-toboggan-md mantis-toboggan-md self-assigned this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/unit-test Issues involving need, configuration or changes of unit test area/vue3 kind/tech-debt Technical debt QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants