Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3: Finish the migration from v-tooltip library to floating-vue #11763

Closed
9 tasks
momesgin opened this issue Aug 28, 2024 · 1 comment · Fixed by #11880
Closed
9 tasks

Vue3: Finish the migration from v-tooltip library to floating-vue #11763

momesgin opened this issue Aug 28, 2024 · 1 comment · Fixed by #11880
Assignees
Labels
area/vue3 kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@momesgin
Copy link
Member

momesgin commented Aug 28, 2024

There's this migration documentation from the floating-vue library that lists the changes that we need to apply in order to complete the migration.

  • All the class names from v-tooltip used in our css to customize the tooltips styling should be updated to the class names from floating-vue e.g. in https://github.com/rancher/dashboard/blob/master/shell/assets/styles/global/_tooltip.scss
    There's this PR that addresses some of the cases

  • Update :popper-options="{modifiers: { flip: { enabled: false } } }" to :flip="false"

  • Replace classes with popperClass

  • Update trigger to :triggers

  • Update open-group to show-group

  • Address the two issues that are mentioned in the comments of this PR, 1. Tooltip's box-shadow 2. Todo comment

  • Fix LocaleSelector dropdown
    result:
    Image
    expected:
    Image

  • Fix Tooltip's content including pre tags
    result:
    Image
    expected:
    Image

  • Fix ContainerLogs dropdown
    result:
    Image
    expected:
    Image

@momesgin momesgin added this to the v2.10.0 milestone Aug 28, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Aug 28, 2024
@momesgin momesgin changed the title Vue3: Migration from v-tooltip library to floating-vue Vue3: Finish the migration from v-tooltip library to floating-vue Aug 28, 2024
@izaac
Copy link
Contributor

izaac commented Sep 20, 2024

This is part of the non functional updates dor the vue2 to vue3 upgrade, and is already covered on other referenced epic/issues

@izaac izaac closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vue3 kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants