Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several issues on Pod detail view #11905

Open
cnotv opened this issue Sep 12, 2024 · 5 comments · May be fixed by #11980
Open

Several issues on Pod detail view #11905

cnotv opened this issue Sep 12, 2024 · 5 comments · May be fixed by #11980
Assignees
Labels
area/vue3 kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@cnotv
Copy link
Contributor

cnotv commented Sep 12, 2024

Description

Several issues have been found in the Pod details page.

  1. Extra editor tab
  2. Extra Namespace column in the table
  3. Tiny cosmetic issue: the space is trimmed

2.10
Screenshot 2024-09-12 at 21 11 24

2.9
Screenshot 2024-09-12 at 21 10 49

@cnotv cnotv added this to the v2.10.0 milestone Sep 12, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Sep 12, 2024
@gaktive
Copy link
Member

gaktive commented Sep 18, 2024

@richard-cox believes this is tied to the inherent attributes being missing, so it needs to be added to the components.

@aalves08 aalves08 linked a pull request Sep 20, 2024 that will close this issue
7 tasks
@aalves08
Copy link
Member

aalves08 commented Sep 20, 2024

1- There's a PR that fixes the problem with the lack of spacing in the restart counts.

2 - The namespace col is not appearing anymore... Couldn't repro that.

2.9
Image

2.10
Image

3- The YAML button part:

in 2.9:
https://github.com/rancher/dashboard/blob/release-2.9/shell/components/ResourceDetail/index.vue#L389
https://github.com/rancher/dashboard/blob/release-2.9/shell/components/ResourceDetail/Masthead.vue#L31-L88 -> note that there is no prop canViewYaml hence why the button is not appearing, because all of the plumbing was there already…

master:
https://github.com/rancher/dashboard/blob/master/shell/components/ResourceDetail/index.vue#L392 -> same prop being passed
https://github.com/rancher/dashboard/blob/master/shell/components/ResourceDetail/Masthead.vue#L89-L92 -> Phil added the missing prop…. Now it’s connected, therefore the YAML button appears -----> part of vue3 migration PR

This is now a global problem.... Either we display it or we don't. I think that the lack of prop was on "purpose" to avoid lengthy changes in configs for individual resources and all.
If the decision is to not show it, maybe we can "fix" it by explicitly defining the canYaml as false in the resource-class model.

I don't know if it has implications in the Edit via YAML or not, which should be pondered, but if possible, I would like to avoid setting configs individually...

Food for thought 🤔

@aalves08
Copy link
Member

@richard-cox , regarding the YAML button part, what is the best course of action? I am only missing that part to move this PR out of draft 🙏

@richard-cox
Copy link
Member

Seems like this is an issue as old as time. Can you bring it up in the sync? i have a feeling then the visibility of the YAML button should remain

@aalves08
Copy link
Member

aalves08 commented Sep 23, 2024

As discussed with @richard-cox and @kwwii , the extra editor tab (YAML button) is to be present on all views

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vue3 kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants