Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS property ::v-deep not migrated correctly #11952

Open
cnotv opened this issue Sep 18, 2024 · 1 comment
Open

CSS property ::v-deep not migrated correctly #11952

cnotv opened this issue Sep 18, 2024 · 1 comment
Assignees
Labels
area/vue3 kind/bug QA/manual-test Indicates issue requires manually testing
Milestone

Comments

@cnotv
Copy link
Contributor

cnotv commented Sep 18, 2024

Description

The ::v-deep property has not been correctly migrated, as it's supposed to be replaced by the function :deep() which has to include the selector as argument.

Several styling seems to be affected which will require to be corrected en-masse.

Example occurrences:

Screenshot 2024-09-18 at 14 51 37

Notes

All these occurrences are bad practices and have to be corrected with more time afterward: #11943

@cnotv cnotv added this to the v2.10.0 milestone Sep 18, 2024
@cnotv cnotv self-assigned this Sep 18, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Sep 18, 2024
@cnotv cnotv added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Sep 18, 2024
@cnotv
Copy link
Contributor Author

cnotv commented Sep 18, 2024

23 files require manual correction due to the complexity and variety of syntax.

Screenshot 2024-09-18 at 15 55 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vue3 kind/bug QA/manual-test Indicates issue requires manually testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant