From a65ce70962d968be214c55d89753bba78ea50ab2 Mon Sep 17 00:00:00 2001
From: Hendrik Ranocha <ranocha@users.noreply.github.com>
Date: Fri, 17 Jun 2022 11:57:46 +0200
Subject: [PATCH] tests using Aqua.jl (#139)

* remove undefined exports

* add tests with Aqua.jl

* set version to v0.5.18
---
 Project.toml                     | 2 +-
 src/SummationByPartsOperators.jl | 2 +-
 test/Project.toml                | 2 ++
 test/aqua.jl                     | 7 +++++++
 test/runtests.jl                 | 1 +
 5 files changed, 12 insertions(+), 2 deletions(-)
 create mode 100644 test/aqua.jl

diff --git a/Project.toml b/Project.toml
index 6ac5c726..e1292af4 100644
--- a/Project.toml
+++ b/Project.toml
@@ -1,7 +1,7 @@
 name = "SummationByPartsOperators"
 uuid = "9f78cca6-572e-554e-b819-917d2f1cf240"
 author = ["Hendrik Ranocha"]
-version = "0.5.17"
+version = "0.5.18"
 
 [deps]
 ArgCheck = "dce04be8-c92d-5529-be00-80e4d2c0e197"
diff --git a/src/SummationByPartsOperators.jl b/src/SummationByPartsOperators.jl
index f0bafd92..d32b42a8 100644
--- a/src/SummationByPartsOperators.jl
+++ b/src/SummationByPartsOperators.jl
@@ -137,7 +137,7 @@ export integrate, left_boundary_weight, right_boundary_weight,
        compute_coefficients, compute_coefficients!
 export periodic_central_derivative_operator, periodic_derivative_operator, derivative_operator,
        dissipation_operator, var_coef_derivative_operator,
-       fourier_derivative_operator, spectral_viscosity_operator, super_spectral_viscosity_operator,
+       fourier_derivative_operator,
        legendre_derivative_operator, legendre_second_derivative_operator
 export UniformMesh1D, UniformPeriodicMesh1D
 export couple_continuously, couple_discontinuously
diff --git a/test/Project.toml b/test/Project.toml
index 1e32ca7c..2460b91f 100644
--- a/test/Project.toml
+++ b/test/Project.toml
@@ -1,4 +1,5 @@
 [deps]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 BandedMatrices = "aae01518-5342-5314-be14-df237901396f"
 DiffEqCallbacks = "459566f4-90b8-5000-8ac3-15dfb0a30def"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
@@ -10,6 +11,7 @@ StructArrays = "09ab397b-f2b6-538f-b94a-2f83cf4a842a"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [compat]
+Aqua = "0.5"
 BandedMatrices = "0.15, 0.16, 0.17"
 DiffEqCallbacks = "2"
 OrdinaryDiffEq = "5, 6"
diff --git a/test/aqua.jl b/test/aqua.jl
new file mode 100644
index 00000000..7534dd6b
--- /dev/null
+++ b/test/aqua.jl
@@ -0,0 +1,7 @@
+using Aqua
+using SummationByPartsOperators
+
+Aqua.test_all(SummationByPartsOperators;
+  ambiguities=false, # a lot of false positives from dependencies
+  unbound_args=false # TODO: a strange problem I do not understand right now
+)
diff --git a/test/runtests.jl b/test/runtests.jl
index 804b6825..a76413b5 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -15,6 +15,7 @@ const SBP_TEST = get(ENV, "SBP_TEST", "all")
         @time @testset "Sum of Operators" begin include("sum_of_operators_test.jl") end
         @time @testset "Upwind Operators" begin include("upwind_operators_test.jl") end
         @time @testset "Special Matrix Types" begin include("special_matrix_types.jl") end
+        @time @testset "Aqua" begin include("aqua.jl") end
     end
 
     @time if SBP_TEST == "all" || SBP_TEST == "part2"