-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enumerable serialization in query strings failing #432
Comments
@eduardocampano I have a fix for this, but it'll only do part of what you want -- it'll do the commas, but the commas will be urlencoded, so the result looks like this:
|
Wow, that was fast, I guess it's the way it's working in |
@eduardocampano there were a couple of UrlEncoding fixes in 4.2 as well, so it may not be 100% the same. |
@eduardocampano if you can confirm this works for you, I can merge it in. Thanks. |
@onovotny confirmed it works, thanks for the quick fix |
Will try to get a |
We run into an issue when updating from
4.0.1
to4.2.0
. We relied on a customIUrlParameterFormatter
to serializeIEnumerable
into comma separated values. After updating to4.2.0
we started having issues with query string parameters and it looks likeIEnumerable
is being serialized withBuildQueryMap
probably because of theDoNotConvertToQueryMap
being incorrect in this scenario.Here is an example of our interface:
When calling
apiClient.GetCompanies(new[] {Guid.NewGuid(), Guid.NewGuid()})
we get a query string likeThe text was updated successfully, but these errors were encountered: