Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonizing and Integrating LearningAlly Windows work into Readium #114

Closed
rkwright opened this issue Nov 5, 2014 · 3 comments
Closed

Comments

@rkwright
Copy link
Member

rkwright commented Nov 5, 2014

Learning Ally has done a fair amount of work getting a WIndows Launcher to work with Visual Studio 2013 and Windows 7. Unfortunately, some of the integration was not done in an ideal fashion.
In particular, the following issues current exist:

  • The naming seems a little odd, compared to the other Launchers. The other Launchers simply re-use the same name for subfolders, project file, etc. e.g. SDKLauncher-OSX.xcodeproject. The Windows one is ReadiumSDKWinLauncherMFC, then has a subfolder that is ReadiumSDKWinLauncher. It’s not a big deal but it would have been better if it were consistent so we (Readium) present a consistent development look and feel.
  • Readium SDK is not a submodule, as it is everywhere else.
  • Shared-js isn’t a submodule either. In fact it is the sub-folder ReadiumSDKWinLauncher.
    AND shared-js appears to be there twice, as readium-shared-js and as readium-shared-js-0.10?
    Let’s discuss these issues at the eng meeting.
  • There is only a master branch, which is understandable for an initial commit, but the project needs to be harmonized with the gitflow workflow
  • None of the new files have licenses, but this is not an immediate issue.

So, it appears that what needs to be done is:

  1. Rename some of the folders plus perhaps some re-arrangement so the structure of the Launcher and the project is similar to the other Launchers
  2. The use of the SDK core and shared-js need to be integrated as submodules
  3. The above needs to be done initially in the master branch, but then merged back into develop in the typical gitflow workflow
  4. The licenses in the files need to be added as appropriate (all BSD, actually).
@rkwright rkwright added this to the m1.1 milestone Nov 5, 2014
@danielweck
Copy link
Member

Should this issue be moved there?
https://github.com/readium/SDKLauncher-Windows/issues

Also, we can then close this one as "duplicate": https://github.com/readium/SDKLauncher-Windows/issues/3

@rkwright
Copy link
Member Author

Yes, good point. What was I thinking? :-)

@danielweck
Copy link
Member

Moved to the correct repository: https://github.com/readium/SDKLauncher-Windows/issues/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants