You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Learning Ally has done a fair amount of work getting a WIndows Launcher to work with Visual Studio 2013 and Windows 7. Unfortunately, some of the integration was not done in an ideal fashion.
In particular, the following issues current exist:
The naming seems a little odd, compared to the other Launchers. The other Launchers simply re-use the same name for subfolders, project file, etc. e.g. SDKLauncher-OSX.xcodeproject. The Windows one is ReadiumSDKWinLauncherMFC, then has a subfolder that is ReadiumSDKWinLauncher. It’s not a big deal but it would have been better if it were consistent so we (Readium) present a consistent development look and feel.
Readium SDK is not a submodule, as it is everywhere else.
Shared-js isn’t a submodule either. In fact it is the sub-folder ReadiumSDKWinLauncher.
AND shared-js appears to be there twice, as readium-shared-js and as readium-shared-js-0.10?
Let’s discuss these issues at the eng meeting.
There is only a master branch, which is understandable for an initial commit, but the project needs to be harmonized with the gitflow workflow
None of the new files have licenses, but this is not an immediate issue.
So, it appears that what needs to be done is:
Rename some of the folders plus perhaps some re-arrangement so the structure of the Launcher and the project is similar to the other Launchers
The use of the SDK core and shared-js need to be integrated as submodules
The above needs to be done initially in the master branch, but then merged back into develop in the typical gitflow workflow
The licenses in the files need to be added as appropriate (all BSD, actually).
The text was updated successfully, but these errors were encountered:
Learning Ally has done a fair amount of work getting a WIndows Launcher to work with Visual Studio 2013 and Windows 7. Unfortunately, some of the integration was not done in an ideal fashion.
In particular, the following issues current exist:
AND shared-js appears to be there twice, as readium-shared-js and as readium-shared-js-0.10?
Let’s discuss these issues at the eng meeting.
So, it appears that what needs to be done is:
The text was updated successfully, but these errors were encountered: