Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redisLibuvPoll crash when server closes the connetion #545

Closed
mannol opened this issue Sep 18, 2017 · 1 comment
Closed

redisLibuvPoll crash when server closes the connetion #545

mannol opened this issue Sep 18, 2017 · 1 comment

Comments

@mannol
Copy link

mannol commented Sep 18, 2017

When server closes the connection, either by shutting down or some protocol irregularity, the libuv adapter crashes in redisLibuvPoll() when calling redisAsyncHandleWrite(). Reason for the crash is that the prior call to redisAsyncHandleRead() frees the context.

I have solved it by placing redisAsyncHandleWrite() before redisAsyncHandleRead(), however, considering that this happens because redisBufferRead(c) == REDIS_ERR causes the __redisAsyncDisconnect(ac) call, the better solution would be to make redisAsyncHandleRead() and redisAsyncHandleWrite() return status.

@michael-grunder
Copy link
Collaborator

Hi, I'm going through old issues.

I think this may have been fixed in 9ce15c4. Please reopen if that actually doesn't solve the problem and I will take the time to replicate the bug and submit a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants