Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ugly hacks from Azure test #615

Closed
mihaitodor opened this issue Jan 12, 2021 · 3 comments
Closed

Remove ugly hacks from Azure test #615

mihaitodor opened this issue Jan 12, 2021 · 3 comments
Labels
enhancement testing An issue relating exclusively to tests

Comments

@mihaitodor
Copy link
Collaborator

The time parsing bug has been fixed in Azurite (that was fast!), so the next release should allow us to drop this ugly hack. I'll make this change once they push a new release.

Unfortunately, we still need to hack the host on each request if we want to use a random port for Azurite instead of letting it start on port 10000, which might clash with other things.

@Jeffail Jeffail added enhancement testing An issue relating exclusively to tests labels Jan 12, 2021
@Jeffail
Copy link
Collaborator

Jeffail commented Jan 12, 2021

Awesome, thanks @mihaitodor for raising that issue and for the follow up.

@mihaitodor mihaitodor changed the title Remove ugly hack from Azure test Remove ugly hacks from Azure test Feb 16, 2021
@mihaitodor
Copy link
Collaborator Author

mihaitodor commented Feb 16, 2021

Before I can enable this test, there are a couple more bugs which need to be fixed:

@mihaitodor
Copy link
Collaborator Author

Fixed in #1901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement testing An issue relating exclusively to tests
Projects
None yet
Development

No branches or pull requests

2 participants