From 0b987b60652ff41273462745ef3158a2dcf074e8 Mon Sep 17 00:00:00 2001 From: Michal Maslanka Date: Tue, 17 May 2022 11:03:50 +0200 Subject: [PATCH] k/group_manager: capture group in first stage finally Extend group lifecycle in both the first and second stage of join and sync request processing. Signed-off-by: Michal Maslanka --- src/v/kafka/server/group_manager.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/v/kafka/server/group_manager.cc b/src/v/kafka/server/group_manager.cc index e8e425adeacc4..e33620464b1f6 100644 --- a/src/v/kafka/server/group_manager.cc +++ b/src/v/kafka/server/group_manager.cc @@ -555,7 +555,7 @@ group::join_group_stages group_manager::join_group(join_group_request&& r) { auto ret = group->handle_join_group(std::move(r), is_new_group); return group::join_group_stages( - std::move(ret.dispatched), ret.result.finally([group] {})); + ret.dispatched.finally([group] {}), ret.result.finally([group] {})); } group::sync_group_stages group_manager::sync_group(sync_group_request&& r) { @@ -586,7 +586,8 @@ group::sync_group_stages group_manager::sync_group(sync_group_request&& r) { if (group) { auto stages = group->handle_sync_group(std::move(r)); return group::sync_group_stages( - std::move(stages.dispatched), stages.result.finally([group] {})); + stages.dispatched.finally([group] {}), + stages.result.finally([group] {})); } else { vlog( klog.trace,