From ad33f1416c86a832f53aa0b11672c88841baa080 Mon Sep 17 00:00:00 2001 From: Rogger Vasquez Date: Tue, 5 Jul 2022 14:35:41 -0500 Subject: [PATCH] rpk: allow write_disk_cache to fail in rpk tune write_disk_cache is only supported for gpc and this makes it a good candidate to be a allowed_to_fail tuner. --- src/go/rpk/pkg/cli/cmd/redpanda/tune.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/go/rpk/pkg/cli/cmd/redpanda/tune.go b/src/go/rpk/pkg/cli/cmd/redpanda/tune.go index 46a3e586c42e..acd15157f98e 100644 --- a/src/go/rpk/pkg/cli/cmd/redpanda/tune.go +++ b/src/go/rpk/pkg/cli/cmd/redpanda/tune.go @@ -181,8 +181,10 @@ func tune( supported, reason := tuner.CheckIfSupported() if !enabled || !supported { includeErr = includeErr || !supported - exit1 = exit1 || enabled && !supported results = append(results, result{tunerName, false, enabled, supported, reason}) + // We exit with code 1 when it's enabled and not supported except + // for disk_write_cache since it's only supported for GCP. + exit1 = exit1 || enabled && !supported && tunerName != "disk_write_cache" continue } log.Debugf("Tuner parameters %+v", params) @@ -192,8 +194,6 @@ func tune( errMsg := "" if res.IsFailed() { errMsg = res.Error().Error() - // We exit with code 1 when it's enabled and not supported - // or when one tuner fails. exit1 = true } results = append(results, result{tunerName, !res.IsFailed(), enabled, supported, errMsg})