Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: mode production set group partitions to be greater than 1 #1567

Closed
emaxerrno opened this issue Jun 10, 2021 · 6 comments
Closed

rpk: mode production set group partitions to be greater than 1 #1567

emaxerrno opened this issue Jun 10, 2021 · 6 comments
Assignees
Labels
area/rpk kind/enhance New feature or request

Comments

@emaxerrno
Copy link
Contributor

https://github.com/vectorizedio/redpanda/blob/dev/src/v/config/configuration.cc#L363-L368

Should be set to 16 or 32 or smth like that when doing rpk mode production on the command line.

@dotnwat - does it use the default replication factor or how does it know what's the default replication factor?

@emaxerrno emaxerrno added area/rpk kind/enhance New feature or request labels Jun 10, 2021
@emaxerrno
Copy link
Contributor Author

basically something like this in the rpk config - though i'm not sure we expose all of these settings.

offsets.topic.num.partitions=16
offsets.topic.replication.factor=3
offsets.commit.required.acks=-1

@twmb
Copy link
Contributor

twmb commented May 4, 2022

Isn't the default for redpanda now to have 3 nodes if the cluster grows to a size of 3? cc @jcsp

@jcsp
Copy link
Contributor

jcsp commented May 4, 2022

I think this ticket is about partition counts rather than replication factor (i.e. group_topic_partitions)

@twmb twmb assigned r-vasquez and unassigned twmb Jul 19, 2022
@mmedenjak
Copy link
Contributor

I guess this is related - #5412 (we bumped the default already for 22.2).

@twmb
Copy link
Contributor

twmb commented Jul 29, 2022

Depends on #5661

@twmb
Copy link
Contributor

twmb commented Oct 31, 2022

group_topic_partitions now defaults to 16, so we no longer need to change this from rpk between dev & prod mode.

https://github.com/redpanda-data/redpanda/blob/dev/src/go/rpk/pkg/cli/cmd/redpanda/start.go#L1041-L1044

This is also now a cluster configuration (i.e. changed since this issue was created).

I think that since 16 is a fine default (as per the suggestion in the issue description), this is done per #5412.

@twmb twmb closed this as completed Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rpk kind/enhance New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants