Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow rpk redpanda start to run as root without an over ride flag #1919

Closed
rkruze opened this issue Jul 28, 2021 · 3 comments · Fixed by #5061
Closed

Don't allow rpk redpanda start to run as root without an over ride flag #1919

rkruze opened this issue Jul 28, 2021 · 3 comments · Fixed by #5061
Assignees
Labels
area/rpk kind/enhance New feature or request

Comments

@rkruze
Copy link
Contributor

rkruze commented Jul 28, 2021

Currently, if you run rpk redpanda start as root on a node that has the redpanda service installed and configured via systemctl then it will overwrite the config files to be writable only by root and also created several files and folders in the data directory that are owned by root. To avoid this, we should throw an error if you are trying to run rpk redpanda start as root unless you specify a --run-as-root or something similar.

@rkruze rkruze added kind/enhance New feature or request area/rpk labels Jul 28, 2021
@esteban
Copy link
Member

esteban commented Jul 28, 2021

Overwriting configs is bad, shouldn't we generate configuration files only when is explicitly indicated by the operator instead?

@rkruze
Copy link
Contributor Author

rkruze commented Jul 28, 2021

@0x5d can comment, but the framework we use normally rewrites the config when changes or things are not in order.

@0x5d
Copy link
Contributor

0x5d commented Jul 29, 2021

@esteban Some flags, like --kafka-addr, --rpc-addr, etc., can't be passed to redpanda through the CLI when rpk execs into redpanda. Therefore the only way to relay those config values is to update the config file, so that redpanda picks them up when it starts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rpk kind/enhance New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants