Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow fallocate size to be configurable #2876

Closed
twmb opened this issue Nov 5, 2021 · 0 comments · Fixed by #3288
Closed

allow fallocate size to be configurable #2876

twmb opened this issue Nov 5, 2021 · 0 comments · Fixed by #3288
Labels
area/storage good first issue Good for newcomers kind/enhance New feature or request

Comments

@twmb
Copy link
Contributor

twmb commented Nov 5, 2021

Today, redpanda fallocates 32M whenever necessary. We currently inject one raft message into every partition when a topic is created. If I create a topic with 1000 partitions, 32G of my disk is eaten.

The fallocate was chosen to be 32M, and large sizes are beneficial, but it may be useful to have this size be a configuration option.

The fallocate size is already an option internally: https://github.com/vectorizedio/redpanda/blob/dev/src/v/storage/segment_appender.cc#L325
"""
so the disk_log_impl has the info, we really just need to expand the ctor here: https://github.com/vectorizedio/redpanda/blob/dev/src/v/storage/segment.h#L68-L74
"""

This can be a new field in the redpanda section of redpanda.yaml that is used if present, else defaults to 32M if not.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage good first issue Good for newcomers kind/enhance New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants