Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: integrate maintenance mode with lifecycle hooks #3022

Closed
dotnwat opened this issue Nov 19, 2021 · 4 comments · Fixed by #4125
Closed

k8s: integrate maintenance mode with lifecycle hooks #3022

dotnwat opened this issue Nov 19, 2021 · 4 comments · Fixed by #4125
Labels
area/k8s kind/enhance New feature or request

Comments

@dotnwat
Copy link
Member

dotnwat commented Nov 19, 2021

At a minimum, shutting down a node should be graceful (#3020) and rolling restarts should be limited to one node at a time.

To the extent that life cycle hooks can invoke cluster level API endpoints then additional safety can be added such as waiting for cluster to become healthy before moving on to the upgrade of the next node.

There is likely going to be more trade-offs for k8s upgrades that are not driven by the operator because the limitations are what is possible with life cycle hooks.

@dotnwat dotnwat added this to the Rolling upgrade safety milestone Nov 19, 2021
@ivotron ivotron modified the milestones: Rolling upgrade safety, v22.1.1 Feb 23, 2022
@nicolaferraro
Copy link
Member

/backport v22.1.x

@dotnwat dotnwat removed this from the v22.1.1 (Stale) milestone Apr 26, 2022
@jcsp
Copy link
Contributor

jcsp commented Nov 3, 2022

@joejulian @dotnwat is this ticket still relvant?

@dotnwat
Copy link
Member Author

dotnwat commented Nov 16, 2022

i suppose it might be since since have k8s deployments that don't have ephemeral disks. on those systems, we don't need the full decommission/node-add procedure for rolling upgrades. also, probably relevant for normal RP upgrades on ephemeral disk systems.

@joejulian
Copy link
Contributor

"integrate maintenance mode with lifecycle hooks" is implemented if that only means adding the postStart and preStop scripts to put a broker into maintenance mode when shutting down and bringing it out of maintenance mode when coming up.

@jcsp jcsp added the kind/enhance New feature or request label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/k8s kind/enhance New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants