Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use descriptive error type for SASL authentication failures #3562

Closed
NyaliaLui opened this issue Jan 20, 2022 · 0 comments · Fixed by #3536
Closed

Use descriptive error type for SASL authentication failures #3562

NyaliaLui opened this issue Jan 20, 2022 · 0 comments · Fixed by #3536
Assignees
Labels
kind/enhance New feature or request

Comments

@NyaliaLui
Copy link
Contributor

Currently, RP brokers throw an exception of type std::runtime_error when an unexpected SASL authentication failure occurs.
https://github.com/vectorizedio/redpanda/blob/bf5953e45f7d59a4755874047e6bc6726d3cde9e/src/v/kafka/server/requests.cc#L199

A recent slack conversation discussed that type std::runtime_error reads as if the exception was not handled gracefully.

Instead, use a error type that better reflects the situation for SASL authentication failures in the kafka sub-system.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhance New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant