Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serde support to raft service message types #4884

Closed
dotnwat opened this issue May 23, 2022 · 3 comments · Fixed by #5465
Closed

Add serde support to raft service message types #4884

dotnwat opened this issue May 23, 2022 · 3 comments · Fixed by #5465
Labels
area/redpanda kind/enhance New feature or request

Comments

@dotnwat
Copy link
Member

dotnwat commented May 23, 2022

No description provided.

@mmedenjak mmedenjak added kind/enhance New feature or request area/redpanda labels Jul 5, 2022
@mmedenjak
Copy link
Contributor

Is this fixed by #5353?

@dotnwat
Copy link
Member Author

dotnwat commented Jul 12, 2022 •
edited

no. #5353 adds support for all but 2 message types. PR today will finalize that.

i think i should have probably added something like Related: #XXX but using Fixed is problematic because i don't actually want the issue closed by the PR. Any other suggestions on how to handle htis?

@dotnwat dotnwat mentioned this issue Jul 14, 2022
Merged
@mmedenjak mmedenjak mentioned this issue Jul 14, 2022
Merged
@mmedenjak
Copy link
Contributor

Thanks for the info. Yeah, I don't have a strong opinion on this, I was just cleaning up GH a bit.

I just added Fixes partially: #XXX to the PR - satisfies both me and GH since it doesn't auto-close but it's pretty clear to me what happened (also, if you use Partially fixes: #XXX, it does auto-close).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/redpanda kind/enhance New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

raft: add serde support for append entries and heartbeat messages dotnwat/redpanda
2 participants
@dotnwat @mmedenjak