Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk redpanda start strips empty tls from config #5202

Closed
r-vasquez opened this issue Jun 22, 2022 · 0 comments · Fixed by #5061
Closed

rpk redpanda start strips empty tls from config #5202

r-vasquez opened this issue Jun 22, 2022 · 0 comments · Fixed by #5061
Assignees
Labels
area/rpk kind/bug Something isn't working

Comments

@r-vasquez
Copy link
Contributor

Version & Environment

Redpanda version: v22.1.3 (rev d1a4e00)

What went wrong?

rpk redpanda start strips out empty TLS config from redpanda.yaml.

running it with a config like

rpk:
  tls:
    truststore_file: ""
    cert_file: ""
    key_file: ""
  enable_usage_stats: true

will change to

rpk:
  enable_usage_stats: true

What should have happened instead?

If all fields are empty then it should leave the property empty instead of stripping it out:

rpk:
  tls: {}

How to reproduce the issue?

  1. Stop redpanda.
  2. Add empty TLS to your config file, e.g:
rpk:
  tls:
    truststore_file: ""
    cert_file: ""
    key_file: ""
  1. start redpanda using rpk redpanda start
    a. This will change your config file and strip out TLS

You can do this also using a container.

Additional information

This is happening all the time when building the docker image since it takes the sample config file in https://github.com/redpanda-data/redpanda/blob/dev/conf/redpanda.yaml

@r-vasquez r-vasquez added the kind/bug Something isn't working label Jun 22, 2022
@r-vasquez r-vasquez self-assigned this Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rpk kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant