Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rpk] Add deprecation warnings for weak/unsupported types in redpanda configuration file. #5262

Closed
r-vasquez opened this issue Jun 28, 2022 · 1 comment
Assignees
Labels
area/rpk kind/enhance New feature or request

Comments

@r-vasquez
Copy link
Contributor

Who is this for and what problem do they have today?

We want to transition to having a configuration file with strong type check when using rpk, we have been working toward that goal and we need to start printing deprecation warnings so the end-users know where are the problems.

What are the success criteria?

Each time a user runs an rpk command that uses a config file with weak types, rpk should print a deprecation warning like:

redpanda.yaml: Server TLS must be an array; a non-array value in array fields is deprecated and will be removed in the future

Additional notes

Relevant PR: #5061

@twmb
Copy link
Contributor

twmb commented May 26, 2023

After sitting on this for a really long time -- I think it's ok to keep our weak decoding code and not force a deprecation. Closing.

@twmb twmb closed this as completed May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rpk kind/enhance New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants