Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale+compaction tests + make spill_key_index memory size dynamic #5389

Closed
jcsp opened this issue Jul 7, 2022 · 0 comments · Fixed by #5816
Closed

Scale+compaction tests + make spill_key_index memory size dynamic #5389

jcsp opened this issue Jul 7, 2022 · 0 comments · Fixed by #5816
Assignees
Labels
area/storage kind/enhance New feature or request

Comments

@jcsp
Copy link
Contributor

jcsp commented Jul 7, 2022

Followup from #5150 (comment) -- in that PR, spill_key_index got a reference to a storage_resources but not yet any logic to choose its max_mem parameter based on the number of partitions in the system (it still uses a fixed 512kiB).

I didn't do it yet because I didn't have a nice scale test with compaction enabled to validate the new settings, but it's a next step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage kind/enhance New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant