Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve memory estimate for metadata handler #5419

Open
travisdowns opened this issue Jul 11, 2022 · 0 comments
Open

Improve memory estimate for metadata handler #5419

travisdowns opened this issue Jul 11, 2022 · 0 comments
Labels
area/redpanda kind/bug Something isn't working

Comments

@travisdowns
Copy link
Member

travisdowns commented Jul 11, 2022

Version & Environment

Redpanda version: 22.2

What went wrong?

The fix implemented in #4804 is in most cases a larger overestimate of the memory needed (so we went from not-large-enough to a too-large estimate, which is at least safe).

Instead, we can implement a more dynamic memory semaphore approach using a two phases: an initial small estimate for the initial request processing, then a second acquisition of units at the point in processing where we know the exact size of the response and intermediate structures.

This will both avoid the overestimate problem and narrow the region of time where the full memory amount is requested, increasing parallelism when metadata requests are in progress.

JIRA Link: CORE-969

@travisdowns travisdowns added the kind/bug Something isn't working label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants